[FFmpeg-devel] Patch for High color and High bit-depth support

[Debargha Mukherjee]

On Tue, Mar 31, 2015 at 4:08 PM, James Zern <jzern at google.com> wrote:

> On Mon, Mar 30, 2015 at 10:43 AM, Carl Eugen Hoyos <cehoyos at ag.or.at>
> wrote:
> > Debargha Mukherjee <debargha <at> google.com> writes:
> >
> >> -   if (avctx->profile != FF_PROFILE_UNKNOWN)
> >> -       enccfg.g_profile = avctx->profile;
> >> +    if (avctx->profile != FF_PROFILE_UNKNOWN) {
> >> +        enccfg.g_profile = avctx->profile;
> >> +    }
> >
> > Please make this a separate patch, do not mix
> > functional and cosmetic changes.
> >
> > +#ifdef VPX_IMG_FMT_HIGHBITDEPTH
> > +    .pix_fmts       = (const enum AVPixelFormat[]){ AV_PIX_FMT_YUV420P,
> > +                                                    AV_PIX_FMT_YUV422P,
> > +                                                    AV_PIX_FMT_YUV444P,
> >
> > +#else
> > +    .pix_fmts       = (const enum AVPixelFormat[]){ AV_PIX_FMT_YUV420P,
> > +                                                    AV_PIX_FMT_YUV422P,
> > +                                                    AV_PIX_FMT_YUV444P,
> >
> > I don't think this is more readable than having
> > #ifdef VPX_IMG_FMT_HIGHBITDEPTH in the middle of
> > the list. Do you disagree?
> >
>
> This is also modifying the pix_fmts for non-highbitdepth, that should
> probably come first as a separate change.
>

The patch is for supporting both high-color (profile 1) and high bit-depth
(profile 2, 3) encoding.
At least that is how I did it. I have clarified that in the commit message.


> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>



-- 
Debargha Mukherjee, Ph.D.
Staff Software Engineer,
Google, Inc.
Email: debargha at google.com
Phone: 408-234-5956 (cell)