[FFmpeg-devel] [PATCH v2 1/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

[Claudio Freire]

On Tue, Apr 14, 2015 at 4:52 PM, Rostislav Pehlivanov
<atomnuker at gmail.com> wrote:
> Uhh, can't replicate bug here (freshly built ffmpeg, just applied this patch
> only), (md5 for file = 473edd68b91123c3a9c1825271012357). tried other files
> and they encode and play fine. Spectrum also looks fine. I also tested other
> random files out of the samples and they all seem file.
> Know of any other problematic files?

I did a pull, replaced:

if (s->options.pns && start*freq_mul > NOISE_LOW_LIMIT && energy <
uplim * 1.2f) {

with

if (s->options.pns && start*freq_mul > NOISE_LOW_LIMIT && energy <
uplim * 2.2f) {

And ran

/home/claudiofreire/src/ffmpeg/ffmpeg -i
/home/claudiofreire/tmp/audiosamples/ffsamples/aac/ct_faac-adts.aac
-strict -2 -c:a aac -b:a 48k -cutoff 22050 -f adts -aac_pns 1 -y
test.adts

And got the assertion failure. You can try playing with that constant
or simply commenting out the "energy < uplim * X" term to force all
noise, and you will get it.