[FFmpeg-devel] [PATCH 5/5] avformat/mp3dec: alwas prefer xing toc for seeking if present

[Michael Niedermayer]

On Wed, Apr 15, 2015 at 11:17:24AM +0200, wm4 wrote:
> On Tue, 14 Apr 2015 23:12:37 +0200
> Michael Niedermayer <michaelni at gmx.at> wrote:
> 
> > On Tue, Apr 14, 2015 at 09:24:37PM +0200, wm4 wrote:
> > > For consistency. This masked another bug before.
> > > ---
> > >  libavformat/mp3dec.c | 12 ++++++------
> > >  1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > this breaks seeking in CBR files with a xing toc
> > 
> > see: https://trac.ffmpeg.org/ticket/2590 for testcase/example
> 
> The sample file is gone.
> 
> Also at least the sample I have (linked in my other post,
> https://0x0.st/AG.mp3), the header claims CBR, but strictly
> speaking is VBR: the packet size is usually 418 bytes, but
> sometimes 417.

some CBR modes allow +-1 in specific patterns in mp3
ill look at the file later

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150415/1c0dbe7c/attachment.asc>