[FFmpeg-devel] [PATCH 0/5] Fix mp3 gapless support (second try)

[Michael Niedermayer]

On Wed, Apr 15, 2015 at 01:32:11PM +0200, wm4 wrote:
> On Wed, 15 Apr 2015 13:16:20 +0200
> Michael Niedermayer <michaelni at gmx.at> wrote:
> 
> > On Wed, Apr 15, 2015 at 01:12:27PM +0200, wm4 wrote:
> > > On Wed, 15 Apr 2015 12:43:36 +0200
> > > Michael Niedermayer <michaelni at gmx.at> wrote:
> > > 
> > > > On Wed, Apr 15, 2015 at 11:08:02AM +0200, wm4 wrote:
> > > > [...]
> > > > > the start of the file. (Seeking to anywhere else likely won't work,
> > > > > because libavformat tries to use the imperfect xing toc, instead of
> > > > > scanning the frames.)
> > > > 
> > > > btw, you can disable the imperfect xing toc for seeking with
> > > > "-usetoc 0"
> > > 
> > > But that breaks VBR even more, shouldn't it?
> > 
> > libavformat should build a index by linearly scanning the file
> > up to the point where one seeks to, so it should work with vbr
> 
> And how could this be achieved?

it should just work not require anything from the user,
if i just commit the cbr and toc code out i still can seek so the
fallback seems working


> 
> I'm also not very fond of utils.c messing with what the demuxer does.
> It really made developing and debugging this harder. It should be the
> other way around, with the demuxer directly being called by the user,
> and the demuxer invoking generic helpers if it needs to.

i understand, iam not sure though if it was the other way around
if that wouldnt lead to other annoyances like if the fallback case
needs to be changed then all demuxers for which it applies would need
to be changed

The part that IMO we are really missing is clear documentation about
the seeking function interactions

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150415/94e90e84/attachment.asc>