[FFmpeg-devel] [PATCH] webmdashenc: Fix potential memory leak

Vignesh Venkatasubramanian vigneshv at google.com
Mon Apr 20 20:20:41 CEST 2015


Fix potential memory leak in WebM DASH Muxer. This fixes coverity
scan CID 1295088.

Signed-off-by: Vignesh Venkatasubramanian <vigneshv at google.com>
---
 libavformat/webmdashenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/webmdashenc.c b/libavformat/webmdashenc.c
index a8eb8ac..6b94e54 100644
--- a/libavformat/webmdashenc.c
+++ b/libavformat/webmdashenc.c
@@ -398,8 +398,8 @@ static int write_adaptation_set(AVFormatContext *s, int as_index)
         ret = write_representation(s, s->streams[as->streams[i]],
                                    representation_id, !width_in_as,
                                    !height_in_as, !sample_rate_in_as);
-        if (ret) return ret;
         av_free(representation_id);
+        if (ret) return ret;
     }
     avio_printf(s->pb, "</AdaptationSet>\n");
     return 0;
-- 
2.2.0.rc0.207.ga3a616c



More information about the ffmpeg-devel mailing list