[FFmpeg-devel] [FFmpeg-cvslog] libavcodec: Add FLAC API test

[Ludmila Glinskih]

вт, 21 апр. 2015 г. в 6:19, Clément Bœsch <u at pkh.me>:

> On Mon, Apr 20, 2015 at 02:37:27PM +0200, Ludmila Glinskih wrote:
> > ffmpeg | branch: master | Ludmila Glinskih <lglinskih at gmail.com> | Mon
> Apr 20 03:03:08 2015 +0300| [be70c79af2bbbf8818707075ebc376d0be137582] |
> committer: Michael Niedermayer
> >
> > libavcodec: Add FLAC API test
> >
> > Signed-off-by: Ludmila Glinskih <lglinskih at gmail.com>
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> >
> > >
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=be70c79af2bbbf8818707075ebc376d0be137582
> > ---
> >
> >  libavcodec/Makefile        |    1 +
> >  libavcodec/api-flac-test.c |  290
> ++++++++++++++++++++++++++++++++++++++++++++
> >  tests/fate/libavcodec.mak  |    6 +
> >  3 files changed, 297 insertions(+)
> >
> [...]
>
> > +TESTPROGS += api-flac
>
> Mmh... no TESTPROGRES-$(CONFIG_FLAC_DECODER) or similar?
>
For building this test It's not necessary for encodec/decodec to be
available. When FATE tests are running, my test won't be ran without
FLAC-codec/decodec, because in /tests/fate/libavcodec.mak I check
availability of the codec:
FATE_LIBAVCODEC-$(call ENCDEC, FLAC, FLAC) += fate-api-flac


> [...]
> > +    if (!ctx)
> > +    {
>
> Sorry to comment on such superficial issue, but this style (repeated all
> over the file) is an obvious violation of the coding style of the project.
> If the author or the person pushing the patch could fix this, that would
> be appreciated.
>
Ok, I'll fix it!)


> Thanks
>
> [...]
>
> --
> Clément B.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

Kind regards,
Ludmila Glinskih