[FFmpeg-devel] Patch[1/2]: Fix bug for PPC LE in file libswscale/ppc/swscale_altivec.c

[Michael Niedermayer]

On Mon, Apr 27, 2015 at 08:27:23PM +0200, Andreas Cadhalpun wrote:
> On 27.04.2015 20:19, Michael Niedermayer wrote:
> > On Mon, Apr 27, 2015 at 07:18:46PM +0200, Andreas Cadhalpun wrote:
> >> On 27.04.2015 13:11, Michael Niedermayer wrote:
> >>> On Mon, Apr 27, 2015 at 02:50:12PM +0800, rongyan wrote:
> >>>> Hi,
> >>>> GCC tool has a bug of PPC intrinsic interpret, which has been fixed in GCC 4.9.1. This bug lead to errors in two of our previous patches. We found this when we update our GCC tools to 4.9.1 and by reading the related info on GCC website. We fix our previous error in two seperate patches:
> >>>>  1. The first patch is to fix libswscale/ppc/swscale_altivec.c by remove the macro GET_VF().
> >>>>  2. The second patch is to roll back the commit af5fec9538d88540af5bb2dd0e4b91162ce6fa13 on Apr. 3rd for file libavcodec/ppc/fdctdsp.c, wherer the macros VEC_FMERGEH() and VEC_FMERGEL() are removed.
> >>>>  This is the first patch.
> >>>>   
> >>>>  The fate test result on both BE and LE is as follows:
> >>>>
> >>>>  
> >>>>   
> >>>>  Thanks for your review.
> >>>>  Rong Yan
> >>>
> >>>
> >>>>  swscale_altivec.c |   11 ++---------
> >>>>  1 file changed, 2 insertions(+), 9 deletions(-)
> >>>> bfa7c88fee1b2cd16b5a4dcaa009c3b79f3fbd47  0001-libswscale-ppc-swscale_altivec.c-POWER-LE-support-in.patch
> >>>> From ca23e69123331a81ce2465da9b692ddf60fe91cc Mon Sep 17 00:00:00 2001
> >>>> From: Rong Yan <rongyan236 at gmail.com>
> >>>> Date: Mon, 27 Apr 2015 03:19:45 +0000
> >>>> Subject: [PATCH 1/2] libswscale/ppc/swscale_altivec.c: POWER LE support in
> >>>>  yuv2planeX_8() delete macro GET_VF() for gcc-4.9.1
> >>>
> >>> applied
> >>>
> >>> thanks
> >>
> >> This fixes the test failures on Debian's ppc64el, so it would be nice
> >> if it was backported to the 2.6 branch.
> > 
> > only this commit or both ?
> 
> This one commit is sufficient to fix the limited tests run during a Debian build.
> I havn't tried a full FATE test run with samples.

the 2nd isnt neeed in any release, ill backport the needed one

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150427/d61d9234/attachment.asc>