[FFmpeg-devel] [PATCH 1/2] OpenCL: Fix ABI incompatibility issues

[Michael Niedermayer]

On Tue, Apr 28, 2015 at 07:43:48AM +0000, Gupta, Maneesh wrote:
> > -----Original Message-----
> > From: ffmpeg-devel-bounces at ffmpeg.org [mailto:ffmpeg-devel-
> > bounces at ffmpeg.org] On Behalf Of Michael Niedermayer
> > Sent: Monday, April 27, 2015 4:57 PM
> > To: FFmpeg development discussions and patches
> > Subject: Re: [FFmpeg-devel] [PATCH 1/2] OpenCL: Fix ABI incompatibility
> > issues
> > 
> > On Mon, Apr 27, 2015 at 07:51:33AM +0000, Gupta, Maneesh wrote:
> > > Hi,
> > >
> > > This patch attempts to fix the ABI incompatibility issues in the OpenCL
> > code. Please review it and let me know if there is anything that I missed
> > addressing in this patch.
> > >
> > > Regards,
> > > Maneesh
> > 
> > >  opencl.c |   42 ++++++++++++++++++++++++++++++++++++++----
> > >  opencl.h |   10 ++--------
> > >  2 files changed, 40 insertions(+), 12 deletions(-)
> > > 091096c9ceb25f09140cbf6e4551c879a84696b4
> > > 0001-OpenCL-Fix-ABI-incompatibility-issues.patch
> > > From 29a69771bd95e230525b67f24694a68ac8ebbade Mon Sep 17 00:00:00
> > 2001
> > > From: Maneesh Gupta <maneesh.gupta at amd.com>
> > > Date: Sat, 25 Apr 2015 11:16:35 +0530
> > 
> > > Subject: [PATCH 1/2] OpenCL: Fix ABI incompatibility issues
> > 
> > this commit message is unacceptable
> > 
> > its too terse
> > please explain, what is changed, why it is changed, and how this is achived in
> > the commit message
> > 
> [Gupta, Maneesh] Attached is the updated patch.

>  opencl.c |   42 ++++++++++++++++++++++++++++++++++++++----
>  opencl.h |   10 ++--------
>  2 files changed, 40 insertions(+), 12 deletions(-)
> 372c3475d95acd45454b14fc64f557b280ececa6  0001-OpenCL-Fix-ABI-incompatibility-issues.patch
> From 555f7a9c3fa8d771f533b7f9d3434ad05f166cf3 Mon Sep 17 00:00:00 2001
> From: Maneesh Gupta <maneesh.gupta at amd.com>
> Date: Tue, 28 Apr 2015 13:02:38 +0530
> Subject: [PATCH 1/2] OpenCL: Fix ABI incompatibility issues
> 
> AVOpenCLDeviceNode and AVOpenCLPlatformNode used fixed static buffer for holding the device and platform name. This patch modifies these structures to use pointers instead. The memory required to hold the names is now dynamically allocated, the size for which is determined by querying appropriate OpenCL runtime APIs.
> 
> Signed-off-by: Maneesh Gupta <maneesh.gupta at amd.com>
> ---
>  libavutil/opencl.c | 42 ++++++++++++++++++++++++++++++++++++++----
>  libavutil/opencl.h | 10 ++--------
>  2 files changed, 40 insertions(+), 12 deletions(-)

applied

please keep the length of lines in commit messages below 80 in future
patches

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150428/5ff3dec5/attachment.asc>