[FFmpeg-devel] [PATCH] Adobe HTTP Dynamic Streaming (HDS) demuxer improvements

[wm4]

On Tue, 28 Apr 2015 14:48:42 +0200
Gorilla Maguila <gorilla.maguila at gmail.com> wrote:

> From 5bb2e85f2e7c4dfeb3569225e263ddc6a4f127cd Mon Sep 17 00:00:00 2001
> From: Developer Mobdro <developer at mobdro.com>
> Date: Tue, 28 Apr 2015 14:38:35 +0200
> Subject: [PATCH] hds demuxer
> 
> ---

> +    mdat->data = av_mallocz(sizeof(uint8_t)*data_size);

You do sizeof(uint8_t) in a bunch of places, but its value is always 1.
(And if not, there should have been overflow checks.)

> +
> +static int hds_probe(AVProbeData *p)
> +{
> +    if(p->filename && av_stristr(p->filename, ".f4m"))
> +        return AVPROBE_SCORE_MAX;
> +    return 0;
> +}

I don't know the format, but hds_read_header() seems to do elaborate
stuff, so the file could probably be detected on content? Or at least
not break everything else if the extension turned out misleading.