[FFmpeg-devel] [PATCH][RFC] ffmpeg: remove access to private FILE struct members on Windows

[Nicolas George]

Le sextidi 16 thermidor, an CCXXIII, Hendrik Leppkes a écrit :
> The FILE struct is opaque in MSVC 2015, and the members of this struct
> were never meant to be accessed in any case.
> 
> No conditions are known where this check was needed to get characters
> from stdin.
> ---
> 
> If someone does know which particular purpose this check serves, please
> do let me know, and I'll be more than willing to find a solution which
> does not involve accessing private/undocumented APIs.

The offending commit is this one:

http://git.videolan.org/?p=ffmpeg.git;a=commit;h=ca4d71b149ebe32aeaf617ffccf362624b9aafb1

It says "Based on code by Rolf Siegrist".

My guess is: the test serves if other parts of the program already did read
from stdin using the stdio API: peek in the sdtdio buffer before reading
from the actual file descriptor.

Since in FFmpeg nothing else reads from stdin, this should not be needed.

Knowing where Rolf Siegrist's code was taken from exactly would help to make
sure.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150803/1a0e6e95/attachment.sig>