[FFmpeg-devel] [PATCH] vc1dec: propagate error codes

[Michael Niedermayer]

On Thu, Aug 06, 2015 at 11:27:00AM +0200, wm4 wrote:
> Also fix some instances of returning -1 as error code.
> ---
> Note that not all of the mpegvideo functions return meaningful error
> codes, but that should be ok for now.
> ---
>  libavcodec/vc1dec.c | 36 ++++++++++++++++++------------------
>  1 file changed, 18 insertions(+), 18 deletions(-)

it seems after this patch there would be "goto err" cases which
dont set ret, potentially leaving it >= 0

for example:
        if ((ret = ff_vc1_decode_init_alloc_tables(v)) < 0) {
            ff_mpv_common_end(s);
            goto err;
        }

        s->low_delay = !avctx->has_b_frames || v->res_sprite;

        if (v->profile == PROFILE_ADVANCED) {
            if(avctx->coded_width<=1 || avctx->coded_height<=1)
                goto err;
                ^^^^^^^^^^

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150806/38278292/attachment.sig>