[FFmpeg-devel] [PATCH 4/4] fate reference for samidec

[Clément Bœsch]

> Subject: Re: [FFmpeg-devel] [PATCH 4/4] fate reference for samidec

no verb sentence. Suggestion: "fate/subtitles: add a new test for SAMI
demuxer and decoder"

On Fri, Aug 07, 2015 at 11:03:31PM -0700, Yayoi wrote:
> ---
>  tests/fate/subtitles.mak |  3 ++
>  tests/ref/fate/sub-sami2 | 91 ++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 94 insertions(+)
>  create mode 100644 tests/ref/fate/sub-sami2
> 
> diff --git a/tests/fate/subtitles.mak b/tests/fate/subtitles.mak
> index d8b2034..0a6c33d 100644
> --- a/tests/fate/subtitles.mak
> +++ b/tests/fate/subtitles.mak
> @@ -46,6 +46,9 @@ fate-sub-realtext: CMD = fmtstdout ass -i $(TARGET_SAMPLES)/sub/RealText_capabil
>  FATE_SUBTITLES_ASS-$(call DEMDEC, SAMI, SAMI) += fate-sub-sami
>  fate-sub-sami: CMD = fmtstdout ass -i $(TARGET_SAMPLES)/sub/SAMI_capability_tester.smi
>  

> +FATE_SUBTITLES_ASS-$(call DEMDEC, SAMI, SAMI) += fate-sub-sami2
> +fate-sub-sami2: CMD = fmtstdout ass -i $(TARGET_SAMPLES)/sub/SAMI_ass_capability_tester.smi
> +

SAMI_capability_tester2.smi or SAMI_multilang_tweak.smi would be better
name. This "ass" is wrong here, there is no ASS markup in this file.

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150808/14519dc4/attachment.sig>