[FFmpeg-devel] [PATCHv2] avcodec/g729: add g729_parser

[Ganesh Ajjanagadde]

On Tue, Aug 11, 2015 at 7:00 PM, Michael Niedermayer
<michael at niedermayer.cc> wrote:
> On Tue, Aug 11, 2015 at 06:08:54PM -0400, Ganesh Ajjanagadde wrote:
>> On Tue, Aug 11, 2015 at 5:16 PM, Michael Niedermayer
>> <michael at niedermayer.cc> wrote:
>> > On Tue, Aug 11, 2015 at 01:04:09PM -0400, Ganesh Ajjanagadde wrote:
>> >> Add trivial g729 parser; fixes Ticket4753
>> >>
>> >> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
>> >> ---
>> >>  libavcodec/Makefile      |  1 +
>> >>  libavcodec/allcodecs.c   |  1 +
>> >>  libavcodec/g729.h        |  4 +++
>> >>  libavcodec/g729_parser.c | 89 ++++++++++++++++++++++++++++++++++++++++++++++++
>> >>  4 files changed, 95 insertions(+)
>> >>  create mode 100644 libavcodec/g729_parser.c
>> >
>> > applied
>> >
>> > thanks
>>
>> Noticed your commit after this (899202) to replace codec_id check with assert.
>> I essentially copied the parser from libavcodec/gsm_parser.c,
>> so you might want to change that file in similar fashion as well.
>
> yes, thanks

Perhaps useful to you (may have some false positives), but
avctx->codec_id check is done in:
mpegaudio_parser.c, rv34_parser.c, vp3_parser.c, aac_ac3_parser.c,
mpegvideo_parser.c

(find . -name '*_parser.c' | xargs grep 'avctx->codec_id')

>
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> I have often repented speaking, but never of holding my tongue.
> -- Xenocrates
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>