[FFmpeg-devel] [PATCH 12/13] buffersink: use sizeof(void *) because AVFilterBufferRef is deprecated

[Michael Niedermayer]

On Sun, Aug 16, 2015 at 06:12:19PM +0200, Andreas Cadhalpun wrote:
> On 16.08.2015 04:53, Michael Niedermayer wrote:
> > On Sat, Aug 08, 2015 at 01:33:14PM +0200, Andreas Cadhalpun wrote:
> >> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> >> ---
> >>  libavfilter/buffersink.c | 12 ++++++------
> >>  1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > should be ok, if sizeof(type)is preferred over sizeof(somevar)
> 
> Well, it was sizeof(type) before...
> But looking at bit more at that code I think that it would be better
> to #define this value to a reasonable name, similar to FIFO_INIT_SIZE.
> 
> Attached patch does this. Do you agree that this is better?
> 
> Best regards,
> Andreas
> 

>  buffersink.c |   16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> b75305dc96f2ec5839e29fb73102b31d62343d73  0001-buffersink-introduce-FIFO_INIT_ELEMENT_SIZE-to-compl.patch
> From 135e02a8765d0a0c4c0dd3d2d78e62498a863225 Mon Sep 17 00:00:00 2001
> From: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> Date: Sun, 16 Aug 2015 17:57:36 +0200
> Subject: [PATCH] buffersink: introduce FIFO_INIT_ELEMENT_SIZE to complement
>  FIFO_INIT_SIZE
> 
> Use sizeof(void *) as its value, because AVFilterBufferRef is deprecated.

LGTM

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150816/5dfd7dad/attachment.sig>