[FFmpeg-devel] [PATCH] Replace all av_dlog() with av_log(AV_LOG_TRACE).

wm4 nfxjfg at googlemail.com
Mon Aug 17 22:28:14 CEST 2015


On Mon, 17 Aug 2015 20:31:57 +0200
Michael Niedermayer <michael at niedermayer.cc> wrote:

> On Mon, Aug 17, 2015 at 12:00:21PM -0400, Ronald S. Bultje wrote:
> [...]
> > diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
> > index 3c1fcdd..a2522ef 100644
> > --- a/libavformat/mpegts.c
> > +++ b/libavformat/mpegts.c
> > @@ -2458,7 +2458,7 @@ static int mpegts_probe(AVProbeData *p)
> >      sumscore = sumscore * CHECK_COUNT / check_count;
> >      maxscore = maxscore * CHECK_COUNT / CHECK_BLOCK;
> >  
> > -    av_dlog(0, "TS score: %d %d\n", sumscore, maxscore);
> > +    av_log(0, AV_LOG_TRACE, "TS score: %d %d\n", sumscore, maxscore);
> 
> cosmetic issue ad unrelated to the patch but it should NULL instead of 0
> 
> [...]

They're equivalent, and also NULL contexts shouldn't be used. If we try
to cleanup all these little issues we'll never make progress. (Or BBB
will never make progress... sorry.)


More information about the ffmpeg-devel mailing list