[FFmpeg-devel] [PATCH 3/3] Replace av_dlog with ff_dlog.

[Michael Niedermayer]

On Mon, Aug 17, 2015 at 08:45:53PM -0400, Ronald S. Bultje wrote:
> ff_dlog checks compilability, and is non-public. av_dlog is deprecated
> and no longer exists if FF_API_DLOG=0.
> ---
>  ffmpeg.c                    |  2 +-
>  libavcodec/ccaption_dec.c   | 13 +++++++------
>  libavcodec/proresdec2.c     |  9 +++++----
>  libavdevice/lavfi.c         |  7 ++++---
>  libavfilter/src_movie.c     |  3 ++-
>  libavfilter/vf_palettegen.c |  5 +++--
>  libavfilter/vf_paletteuse.c |  3 ++-
>  libavfilter/vsrc_cellauto.c |  3 ++-
>  libavfilter/vsrc_life.c     |  3 ++-
>  libavformat/avienc.c        |  5 +++--
>  libavformat/ffmdec.c        |  9 +++++----
>  libavformat/ftp.c           | 23 ++++++++++++-----------
>  libavformat/mov.c           |  3 ++-
>  libavformat/mpegts.c        |  3 ++-
>  libavformat/segment.c       |  3 ++-
>  libavformat/swfdec.c        |  3 ++-
>  16 files changed, 56 insertions(+), 41 deletions(-)

the patch LGTM but
This is missing some av_dlog()
libavcodec/libzvbi-teletextdec.c:        av_dlog(ctx, "palette %0x\n", ((uint32_t *)sub_rect->pict.data[1])[ci]);
libavcodec/libzvbi-teletextdec.c:            av_dlog(avctx, "ctx=%p buf_size=%d lines=%u pkt_pts=%7.3f\n",
libavcodec/libzvbi-teletextdec.c:    av_dlog(avctx, "lines_total=%u\n", ctx->lines_processed);
libavdevice/v4l.c:    av_dlog(s1, "v4l: colour=%d hue=%d brightness=%d constrast=%d whiteness=%d\n",
libavfilter/vf_histeq.c:        av_dlog(ctx, "in[%d]: %u\n", x, histeq->in_histogram[x]);
libavfilter/vf_histeq.c:        av_dlog(ctx, "out[%d]: %u\n", x, histeq->out_histogram[x]);

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150818/c434a010/attachment.sig>