[FFmpeg-devel] [PATCH 1/5] vaapi: define a single pixel format for VA-API (AV_PIX_FMT_VAAPI).

[Gwenole Beauchesne]

Hi,

2015-08-19 0:02 GMT+02:00 Andreas Cadhalpun <andreas.cadhalpun at googlemail.com>:
> On 18.08.2015 17:26, Gwenole Beauchesne wrote:
>> Deprecate older VA pixel formats (MOCO, IDCT) as it is now very unlikely
>> to ever be useful in the future. Only keep plain AV_PIX_FMT_VAAPI format
>> that is aliased to the older VLD variant.
>>
>> Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne at intel.com>
>> ---
>>  libavcodec/h263dec.c     |  2 +-
>>  libavcodec/h264_slice.c  |  2 +-
>>  libavcodec/mpeg12dec.c   |  2 +-
>>  libavcodec/vaapi_h264.c  |  2 +-
>>  libavcodec/vaapi_mpeg2.c |  2 +-
>>  libavcodec/vaapi_mpeg4.c |  4 ++--
>>  libavcodec/vaapi_vc1.c   |  4 ++--
>>  libavcodec/vc1dec.c      |  2 +-
>>  libavutil/pixdesc.c      |  9 +++++++++
>>  libavutil/pixfmt.h       | 12 ++++++++++++
>>  libavutil/version.h      |  3 +++
>>  11 files changed, 34 insertions(+), 10 deletions(-)
>>
> [...]
>> --- a/libavutil/version.h
>> +++ b/libavutil/version.h
>> @@ -107,6 +107,9 @@
>>  #ifndef FF_API_AVFRAME_LAVC
>>  #define FF_API_AVFRAME_LAVC             (LIBAVUTIL_VERSION_MAJOR < 55)
>>  #endif
>> +#ifndef FF_API_VAAPI
>> +#define FF_API_VAAPI                    (LIBAVUTIL_VERSION_MAJOR < 55)
>> +#endif
>
> I think the deprecation should be at least in one release before it is removed.
> Hence using '< 56' would be better.
> Also mentioning this change in doc/APIchanges would be good.
>
> The same goes for FF_API_VAAPI_CONTEXT from the second patch.

You are right. Thanks.

Regards,
-- 
Gwenole Beauchesne
Intel Corporation SAS / 2 rue de Paris, 92196 Meudon Cedex, France
Registration Number (RCS): Nanterre B 302 456 199