[FFmpeg-devel] [PATCH v2 2/3] vaapi: streamline public context structure.

[Michael Niedermayer]

On Wed, Aug 19, 2015 at 11:03:05AM +0200, Gwenole Beauchesne wrote:
> Move libavcodec managed objects from the public struct vaapi_context
> to a new privately owned FFVAContext. This is done so that to clean up
> and streamline the public structure, but also to prepare for new codec
> support, thus requiring new internal data to be added in there.
> 
> The AVCodecContext.hwaccel_context, that holds the public vaapi_context,
> shall no longer be accessed from within vaapi_*.c codec support files.
> 
> v2: add one minor check for hwaccel_context existence, mark older
>   vaapi_context fields as deprecated until we reach lavc major+2,
>   amend doc/APIchanges.
> 
> Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne at intel.com>
> ---
>  doc/APIchanges              |  4 ++++
>  libavcodec/vaapi.c          | 40 +++++++++++++++++++++++++++++++---------
>  libavcodec/vaapi.h          | 16 ++++++++++++++++
>  libavcodec/vaapi_h264.c     | 10 +++++++---
>  libavcodec/vaapi_internal.h | 42 ++++++++++++++++++++++++++++++++++++------
>  libavcodec/vaapi_mpeg2.c    |  8 ++++++--
>  libavcodec/vaapi_mpeg4.c    | 11 +++++++++--
>  libavcodec/vaapi_vc1.c      | 11 +++++++++--
>  libavcodec/version.h        |  3 +++
>  9 files changed, 121 insertions(+), 24 deletions(-)
> 
> diff --git a/doc/APIchanges b/doc/APIchanges
> index f5ba678..7d339ac 100644
> --- a/doc/APIchanges
> +++ b/doc/APIchanges
> @@ -15,6 +15,10 @@ libavutil:     2014-08-09
>  
>  API changes, most recent first:
>  
> +2015-xx-xx - lavc 56.57.0 - vaapi.h
                     ^^^^^^^
this version does not, exist


[...]
> diff --git a/libavcodec/version.h b/libavcodec/version.h
> index 2e7cf40..995c3e9 100644
> --- a/libavcodec/version.h
> +++ b/libavcodec/version.h
> @@ -181,6 +181,9 @@

there should be a micro (or minor) bump here so that APIchanges
can refer to the version in which the deprecation happened

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150819/6c0b8ac7/attachment.sig>