[FFmpeg-devel] [PATCHv2] avformat/webmdashenc: fix uninitialized variable

[Ronald S. Bultje]

Hi,

On Thu, Aug 20, 2015 at 11:18 AM, Ganesh Ajjanagadde <gajjanagadde at gmail.com
> wrote:

> Fixes -Wsometimes-uninitialized from
>
> http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1
>
> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
> ---
>  libavformat/webmdashenc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/libavformat/webmdashenc.c b/libavformat/webmdashenc.c
> index 76ea423..898e464 100644
> --- a/libavformat/webmdashenc.c
> +++ b/libavformat/webmdashenc.c
> @@ -392,10 +392,10 @@ static int write_adaptation_set(AVFormatContext *s,
> int as_index)
>          if (w->is_live) {
>              AVDictionaryEntry *filename =
>                  av_dict_get(s->streams[as->streams[i]]->metadata,
> FILENAME, NULL, 0);
> -            if (!filename ||
> -                (ret = parse_filename(filename->value,
> &representation_id, NULL, NULL))) {
> +            if (!filename)
> +                return AVERROR(EINVAL);
> +            if (ret = parse_filename(filename->value, &representation_id,
> NULL, NULL))
>                  return ret;
> -            }
>          } else {
>              representation_id = av_asprintf("%d", w->representation_id++);
>              if (!representation_id) return AVERROR(ENOMEM);
> --
> 2.5.0


lgtm.

Ronald