[FFmpeg-devel] [PATCH 2/4] avcodec/aacsbr_fixed: remove unused variable

[Michael Niedermayer]

On Thu, Aug 20, 2015 at 04:44:17PM -0400, Ganesh Ajjanagadde wrote:
> On Thu, Aug 20, 2015 at 3:31 PM, Michael Niedermayer
> <michael at niedermayer.cc> wrote:
> > On Thu, Aug 20, 2015 at 09:33:31AM -0400, Ronald S. Bultje wrote:
> >> Hi,
> >>
> >> On Thu, Aug 20, 2015 at 4:28 AM, Ganesh Ajjanagadde <gajjanagadde at gmail.com>
> >> wrote:
> >>
> >> > Fixes -Wunused-const-variable from
> >> >
> >> > http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1
> >> >
> >> > Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
> >> > ---
> >> >  libavcodec/aacsbr_fixed.c | 1 -
> >> >  1 file changed, 1 deletion(-)
> >> >
> >> > diff --git a/libavcodec/aacsbr_fixed.c b/libavcodec/aacsbr_fixed.c
> >> > index 5a5c9cc..1fc7385 100644
> >> > --- a/libavcodec/aacsbr_fixed.c
> >> > +++ b/libavcodec/aacsbr_fixed.c
> >> > @@ -76,7 +76,6 @@ static VLC vlc_sbr[10];
> >> >  static void aacsbr_func_ptr_init(AACSBRContext *c);
> >> >  static const int CONST_LN2       = Q31(0.6931471806/256);  // ln(2)/256
> >> >  static const int CONST_RECIP_LN2 = Q31(0.7213475204);      // 0.5/ln(2)
> >> > -static const int CONST_SQRT2     = Q30(0.7071067812);      // sqrt(2)/2
> >> >  static const int CONST_076923    = Q31(0.76923076923076923077f);
> >>
> >>
> >> ok.
> >
> > applied
> >
> > @Ganesh, if you want a git write account, send me your public ssh key
> 
> Unless you consider it a burden to apply patches as opposed to me pushing,
> I would prefer not to be entrusted with this responsibility at this stage.
> Maybe in a year or two,

np, but please remind me in a year, i will forget

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150820/00fdc240/attachment.sig>