[FFmpeg-devel] [PATCH 1/4] avcodec/metasound_data: remove unused variable

[Ganesh Ajjanagadde]

On Thu, Aug 20, 2015 at 6:37 AM, Michael Niedermayer
<michael at niedermayer.cc> wrote:
> On Thu, Aug 20, 2015 at 04:34:19AM -0400, Ganesh Ajjanagadde wrote:
>> On Thu, Aug 20, 2015 at 4:28 AM, Ganesh Ajjanagadde
>> <gajjanagadde at gmail.com> wrote:
>> > Fixes -Wunused-const-variable from
>> > http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1
>> >
>> > Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
>> > ---
>> >  libavcodec/metasound_data.c | 4 ----
>> >  1 file changed, 4 deletions(-)
>> >
>> > diff --git a/libavcodec/metasound_data.c b/libavcodec/metasound_data.c
>> > index e439b3d..da2548a 100644
>> > --- a/libavcodec/metasound_data.c
>> > +++ b/libavcodec/metasound_data.c
>> > @@ -14946,10 +14946,6 @@ static const uint16_t bark_tab_s16_128[] = {
>> >      2, 2, 2, 3, 3, 5, 7, 12, 25, 67
>> >  };
>> >
>> > -static const uint16_t bark_tab_s16_64[] = {
>> > -    1, 1, 2, 2, 3, 6, 11, 38
>> > -};
>> > -
>> >  static const uint16_t bark_tab_l16s_1024[] = {
>> >        9,   9,   8,   9,  10,   9,  10,  10,
>> >       10,  12,  11,  13,  13,  14,  16,  17,
>> > --
>> > 2.5.0
>> >
>>
>> Some comments:
>> 1. I am still working on the remaining warnings and sent these mainly
>> for feedback.
>> If people think these are too trivial/waste of time I will refrain
>> from these in future.
>
>> 2. If above are ok, I can squash complete warning cleanup (from this
>> file) into single
>> patch if that is preferred.
>
> i dont think this particular table removial should be squashed with
> anything as its quite possible the table would be used in the future
> and a seperate commit is (slihgtly) easier to revert

Perhaps nontrivial unused stuff (which one can't come up with in a few minutes)
should simply be commented out.
It will be easier for a future developer to work on it,
since they won't have to go through the git logs to find the commit removing
the data.

Do you prefer the commenting out, or the deletion?

>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> When the tyrant has disposed of foreign enemies by conquest or treaty, and
> there is nothing more to fear from them, then he is always stirring up
> some war or other, in order that the people may require a leader. -- Plato
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>