[FFmpeg-devel] MP4 muxer, HEVC issues

[Michael Niedermayer]

On Fri, Aug 21, 2015 at 09:47:14AM +0300, Arthur Grant wrote:
> I found two HEVC specific issues in the MP4 muxer.
> 
> 1) File libavformat\hevc.c, hvcc_parse_pps()
> pps_slice_chroma_qp_offsets_present_flag is missing
> 
> -------------
>     /*
>      * weighted_pred_flag               u(1)
>      * weighted_bipred_flag             u(1)
>      * transquant_bypass_enabled_flag   u(1)
>      */
>     skip_bits(gb, 3);
> -------------
> 
> Should be
> 
> -------------
>     /*
>      * pps_slice_chroma_qp_offsets_present_flag u(1)
>      * weighted_pred_flag               u(1)
>      * weighted_bipred_flag             u(1)
>      * transquant_bypass_enabled_flag   u(1)
>      */
>     skip_bits(gb, 4);
> -------------
> 
> 2) File libavformat\hevc.c, hvcc_parse_sps()
> 
> -------------
> for (i = 0; i < get_ue_golomb_long(gb); i++) { // num_long_term_ref_pics_sps
> -------------
> 
> Is not correct. get_ue_golomb_long(gb) is evaluated multiple times.

Fixed

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

During times of universal deceit, telling the truth becomes a
revolutionary act. -- George Orwell
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150824/c82daccd/attachment.sig>