[FFmpeg-devel] [PATCH] Cleaning existing FFV1 tests

[Peter B.]

Am Mo, 31.08.2015, 11:22 schrieb Hendrik Leppkes:
> On Mon, Aug 31, 2015 at 11:13 AM, Peter B. <pb at das-werkstatt.com> wrote:
>>
>> In my case, there are files in "tests/ref/vsynth" that contain the
>> expected reference results from tests.
>>
>> If I only provide the changed the FATE makefiles, like "vcodec.mak", who
>> generates (and validates) the initial reference files?
>>
>
> The references inside the Git tree can be changed just fine if a
> change in the tests warrants it.
> What should not be changed is the samples inside the FATE suite - if a
> change is needed, there should be a new sample with a new name - which
> is probably what Carl refers to.
>
> But since these seem to be vsynth tests, no external samples from the
> FATE suite are actually affected, are  they?

That makes perfect sense now.

The current FFV1 tests only use vsynth*. No external samples.

The reference files in "tests/ref/vsynth" had to be changed, because the
tests were renamed, so the filenames inside the reference textfiles
changed.

So, it is correct if my patch includes "tests/ref/*" in the future?


Regards,
Pb