[FFmpeg-devel] [PATCH] Incorrect FourCC for HE-AAC in ISMV manifest

[Michael Niedermayer]

On Wed, Dec 02, 2015 at 06:31:12PM +0100, Yann Coupin wrote:
> Hi,
> 
> According to Microsoft's specs [1] (and after experiencing issues with the
> Unified Streaming Platform [2] server), content encoded with HE-AAC audio
> should use the AACH FourCC, but the value AACL is hardcoded in the manifest
> generation code. So I created the attached patch to fix this. It passes
> "test fate" and its effects can be seen using the commands bellow and
> compatible server.
> 
> Although I tried to follow the patch submission checklist don't hesitate to
> point errors or mistakes.
> 
> Yann
> 
> 
> Sample command lines:
> 
> ffmpeg -i video.mp4 -vn -acodec libfdk_aac -profile:a aac_low -ab 128k -ar
> 44.1k -movflags isml -f ismv http://example.com/
> 
> FourCC of audio track in manifest is AACL as before
> 
> ffmpeg -i video.mp4 -vn -acodec libfdk_aac -profile:a aac_he -ab 64k -ar
> 44.1k -movflags isml -f ismv http://example.com/
> 
> FourCC is AACH
> 
> ffmpeg -i video.mp4 -vn -acodec libfdk_aac -profile:a aac_he_v2 -ab 64k -ar
> 44.1k -movflags isml -f ismv http://example.com/
> 
> FourCC is AACP
> 
> [1] https://msdn.microsoft.com/en-us/library/ff728116%28v=vs.95%29.aspx
> [2] http://www.unified-streaming.com/

>  movenc.c |   12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> f4e405da303c85b76a70d2fb7c0ca163bcc4ffd0  0001-HE-AAC-correct-FourCC-in-ISML.patch
> From 4962e42d1f2310048486a3fea5d338947ee78f9e Mon Sep 17 00:00:00 2001
> From: Yann Coupin <yann.coupin+ffmpeg at gmail.com>
> Date: Tue, 1 Dec 2015 12:22:38 +0100
> Subject: [PATCH] HE-AAC correct FourCC in ISML
> 
> ---
>  libavformat/movenc.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151204/4123ec90/attachment.sig>