[FFmpeg-devel] [PATCH v3 11/14] mips: do not disable any feature for generic cores

[Andreas Cadhalpun]

On 03.12.2015 14:22, Vicente Olivert Riera wrote:
> We don't know which features are available when the user selects a
> generic core, so let's don't disable anything by default and let the

I think the "let's" doesn't belong there.

> user decide.
> 
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera at imgtec.com>
> ---
> Changes v2 -> v3:
>  - Change the logic of this patch. Instead of removing the generic core,
>    do not disable any feature and add a warning message to state that.
>    The patch subject has also changed accordingly.
> 
> Changes v1 -> v2:
>  - Nothing.
> 
>  configure | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 8bd47b9..2ee10db 100755
> --- a/configure
> +++ b/configure
> @@ -4159,8 +4159,8 @@ elif enabled mips; then
>              esac
>          ;;
>          generic)
> -            disable mips64r6
> -            disable msa
> +            # We do not disable anything. Is up to the user to disable
> +            # the unwanted features.
>          ;;
>          *)
>              disable mipsfpu
> 

The actual change looks good to me.

Best regards,
Andreas