[FFmpeg-devel] [PATCH v3 14/14] mips: display a warning message when using an unknown CPU

[Vicente Olivert Riera]

Hello Andreas,

On 04/12/15 14:32, Andreas Cadhalpun wrote:
> On 03.12.2015 14:22, Vicente Olivert Riera wrote:
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera at imgtec.com>
>> ---
>> Changes v2 -> v3:
>>  - This patch has been added for v3.
>>
>> Changes v1 -> v2:
>>  - This patch didn't exist at that point.
>>
>>  configure | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/configure b/configure
>> index 7d06494..62a5452 100755
>> --- a/configure
>> +++ b/configure
>> @@ -4163,6 +4163,8 @@ elif enabled mips; then
>>              # the unwanted features.
>>          ;;
>>          *)
>> +            # Unknown CPU. Disable everything.
>> +            echo "Warning: unknown CPU. All features disabled by default."
> 
> This sounds strange. I'd rather say:
> 'Warning: unknown CPU. Disabling all mips optimizations.'
> 
> Otherwise looks good.

is the first time I contribute to ffmpeg. Does that issue needs a
re-spin of the 13 patch series, or is it something that the maintainer
can do for me when applying the patch? Same question for your review in
the 11th patch about the "let's".

Regards,

Vincent.

> Best regards,
> Andreas
>