[FFmpeg-devel] support for reading / writing encrypted MP4 files

[Eran Kornblau]

Thank you !

Opened a pull request here: https://github.com/FFmpeg/FFmpeg/pull/162
Currently containing only the encoding part, I will start working on the decoding part and submit another
pull request once it's ready and this one gets merged (it will reuse code from this pull).
I tried to match the existing code standards as much as possible, hope I didn't miss anything :)

I used libavutil/aes as you suggested, however, as a side note, I think it makes sense to move ffmpeg to use 
openssl's implementation. The reason is that openssl's EVP API makes use of AES-NI (https://en.wikipedia.org/wiki/AES_instruction_set)
and is therefore expected to perform significantly better on supported CPUs.

Please let me know if anything else is needed to get this merged

Thanks again

Eran

-----Original Message-----
From: compn [mailto:tempn at mi.rr.com] 
Sent: Wednesday, November 25, 2015 1:56 AM
To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
Cc: Eran Kornblau <eran.kornblau at kaltura.com>; Eran Etam <eran.etam at Kaltura.com>
Subject: Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

On Tue, 24 Nov 2015 12:10:43 +0000
Eran Kornblau <eran.kornblau at kaltura.com> wrote:
> Before we start working on this feature, since we really prefer not
> to manage our own fork of the code, we wanted to check with you
> whether you will be willing to merge such a feature ? (assuming it
> conforms to the coding standards, naturally)

yes, we have support for encrypted wmv so there should be no problem.

try to reuse the crypt code from ffmpeg/libavutil/* where possible. or
consider adding whatever en/decrypt code you need, as we do not like to
use too many external libs.

the more communication you have with ffmpeg developers or the mailing
list, the less problems you will have when merging time happens.

you may also want to post any work in progress patches or do request
for comments on any ideas, so developers do not object about strange
api additions to the code.

feel free to ask any questions.

-compn