[FFmpeg-devel] [PATCH 1/2] avcodec/nvenc: Include NVENC SDK header

[Stefano Sabatini]

On date Monday 2015-12-07 14:53:22 -0300, James Almer encoded:
> On 12/7/2015 11:14 AM, Timo Rothenpieler wrote:
> > Nvidia finaly decided to put a propper MIT license on their nvenc header, so
> > it can be included, removing any external dependencies for nvenc and
> > making it no longer require the non-free flag.
> > 
> > nvenc.h is the original nvEncodeApi.h from the NVENC SDK 6.0.1, with a
> > slight modification to make it work on cygwin.
> > ---
> >  configure          |   25 +-
> >  libavcodec/nvenc.c |    2 +-
> >  libavcodec/nvenc.h | 3122 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 3142 insertions(+), 7 deletions(-)
> >  create mode 100644 libavcodec/nvenc.h
[...]
> > diff --git a/libavcodec/nvenc.h b/libavcodec/nvenc.h
> > new file mode 100644
> > index 0000000..8b67c11
> > --- /dev/null
> > +++ b/libavcodec/nvenc.h
> 

> compat/nvenc/nvenc.h? It's the proper place for non ffmpeg headers, like we
> do with Avisynth.
> Or maybe both nvenc and the Avisynth stuff could be moved to a new "contrib"
> or "thirdparty" folder.

I don't remember if this was discussed when avisynth and other headers
where included, but what's the advantage of directly including the
header and burden the FFmpeg sources, rather than asking the user to
download them in case of need?

Also: cygwin fixes should be sent upstream, rather than maintained in
FFmpeg.
-- 
FFmpeg = Fascinating and Fundamentalist Magical Purposeless Encoding/decoding Game