[FFmpeg-devel] [PATCH 1/2] avcodec/nvenc: Include NVENC SDK header

[wm4]

On Mon, 7 Dec 2015 19:34:20 +0100
Timo Rothenpieler <timo at rothenpieler.org> wrote:

> > I don't remember if this was discussed when avisynth and other headers
> > where included, but what's the advantage of directly including the
> > header and burden the FFmpeg sources, rather than asking the user to
> > download them in case of need?  
> 
> The nvenc sdk isn't exactly a common thing that distributions provide.
> As distributions can now easily ship ffmpeg with nvenc support, this
> propably helps users who now no longer need to build ffmpeg themselves
> for nvenc support.

So why would distros build with nvenc support, if they can't even do a
simple thing like installing a single header file?

Are we really talking about including a huge 3rd party header because
distros are so lazy? What's next, do we add Windows headers to the
FFmpeg tree, because MinGW lags severely behind the newest definitions
like HEVC DXVA support?

We could just provide a download link for the nvenc header somewhere if
the problem is finding the header.

> > Also: cygwin fixes should be sent upstream, rather than maintained in
> > FFmpeg.
> >   
> 
> This isn't primarily about cygwin support. The change is just ||
> defined(__CYGWIN__) that's added to one #if.
> Also, sending patches upstream might take years or could be ignored
> entirely.
>