[FFmpeg-devel] [PATCH]lavf/matroskadec: Parse stsd atom in mkv with the appropriate mov function

Mats Peterson matsp888 at yahoo.com
Mon Dec 14 10:09:55 CET 2015


On 12/14/2015 09:37 AM, Hendrik Leppkes wrote:
> On Mon, Dec 14, 2015 at 3:40 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
>> Hi!
>>
>> Attached patch based on 3ece3e4c by Martin Storsjö fixes ticket #5071 for me.
>> I can't see how duplicating the code from mov.c could be acceptable.
>>
>
> Personally I found toying with st->priv_data to make it look like
> being in the MOV demuxer not acceptable.
> It has the potential for unpredicatble side-effects in the long run.
>
> - Hendrik
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

And it's overkill to parse the stsd atom from the file when you already 
have what you need in the private data.

Mats

-- 
Mats Peterson
http://matsp888.no-ip.org/~mats/


More information about the ffmpeg-devel mailing list