[FFmpeg-devel] [PATCH]lavf/matroskadec: Parse stsd atom in mkv with the appropriate mov function

[Mats Peterson]

On 12/14/2015 12:03 PM, Carl Eugen Hoyos wrote:
> On Monday 14 December 2015 09:37:22 am Hendrik Leppkes wrote:
>> On Mon, Dec 14, 2015 at 3:40 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
>>> Hi!
>>>
>>> Attached patch based on 3ece3e4c by Martin Storsjö fixes ticket #5071 for
>>> me. I can't see how duplicating the code from mov.c could be acceptable.
>>
>> Personally I found toying with st->priv_data to make it look like
>> being in the MOV demuxer not acceptable.
>
> Given that ff_mov_read_stsd_entries() is already used outside of the mov
> demuxer and we generally avoid code duplication and the (very short)
> specification of the structure only mentions it is identical to stsd, I
> consider my patch the more acceptable solution.
>
>> It has the potential for unpredicatble side-effects in the long run.
>
> If this potential exists, it also exists without this patch.
>
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

It does not, since in my patch everything happens inside matroskadec.c.

Mats

-- 
Mats Peterson
http://matsp888.no-ip.org/~mats/