[FFmpeg-devel] [PATCH] on2avc: limit number of bits to 30 in get_egolomb

[Andreas Cadhalpun]

On 17.12.2015 13:28, Michael Niedermayer wrote:
> On Wed, Dec 16, 2015 at 08:20:18PM +0100, Andreas Cadhalpun wrote:
>> More don't fit into the integer output.
>>
>> Also use get_bits_long, since get_bits only supports reading up to 25
>> bits, while get_bits_long supports the full integer range.
>>
>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
>> ---
>>  libavcodec/on2avc.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavcodec/on2avc.c b/libavcodec/on2avc.c
>> index 15f4dd1..10861b5 100644
>> --- a/libavcodec/on2avc.c
>> +++ b/libavcodec/on2avc.c
>> @@ -211,9 +211,9 @@ static inline int get_egolomb(GetBitContext *gb)
>>  {
>>      int v = 4;
>>  
>> -    while (get_bits1(gb)) v++;
>> +    while (get_bits1(gb) && v < 30) v++;
> 
> it could make sense to print a warning or error in case its too long

OK, updated patch attached.

Best regards,
Andreas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-on2avc-limit-number-of-bits-to-30-in-get_egolomb.patch
Type: text/x-diff
Size: 1223 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151217/f0bbc1fd/attachment.patch>