[FFmpeg-devel] [PATCH 01/12] lavfi/vf_idet: replace round and cast by lrint

[Ganesh Ajjanagadde]

On Sat, Dec 19, 2015 at 2:45 AM, Michael Niedermayer
<michael at niedermayer.cc> wrote:
> On Fri, Dec 18, 2015 at 09:45:27PM -0800, Ganesh Ajjanagadde wrote:
>> lrint is faster and conveys the intent better here. It is safe as long int has
>> at least 32 bits.
>>
>> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
>> ---
>>  libavfilter/vf_idet.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> half_life should be checked to be within the defined range of lrint()

sorry, don't understand: exp2 of a negative number is always < 1, so
the lrint operates on a number < PRECISION, which falls within lrint's
range.

>
> should be ok otherwise
>
>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> I know you won't believe me, but the highest form of Human Excellence is
> to question oneself and others. -- Socrates
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>