[FFmpeg-devel] [PATCH v5] lavf: palettized QuickTime video in Matroska

[Alexander Strasser]

On 2015-12-23 13:33 +0100, Hendrik Leppkes wrote:
> Am 23.12.2015 13:28 schrieb "Mats Peterson" <
> matsp888-at-yahoo.com at ffmpeg.org>:
> >
> > On 12/23/2015 01:15 PM, Mats Peterson wrote:
> >>
> >> On 12/23/2015 01:13 PM, Carl Eugen Hoyos wrote:
> >>>
> >>> Mats Peterson <matsp888-at-yahoo.com <at> ffmpeg.org> writes:
> >>>
> >>>>>> In matroskadec.c, I'm also putting the palette in 'extradata',
> >>>>>> like it's done for V_MS/VFW/FOURCC; this is a requirement in
> >>>>>> order for MPlayer to recognize the palette.
> >>>>>
> >>>>>
> >>>>> This is wrong, please remove this hunk.
> >>>
> >>>
> >>>> The reason for this is because MPlayer won't notice the
> >>>> palette otherwise, as I said before.
> >>>
> >>>
> >>> This is not correct.
> >>>
> >>>> Try it yourself.
> >>>
> >>>
> >>> Please do.
> >>>
> >>> Carl Eugen
> >>>
> >>> _______________________________________________
> >>> ffmpeg-devel mailing list
> >>> ffmpeg-devel at ffmpeg.org
> >>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >>>
> >>
> >> Stop this meaningless rant until you've tried it. I know more about this
> >> issue than you do.
> >>
> >> Mats
> >>
> >
> > Let me once and for all clarify the issue with MPlayer and the palette
> for you, Eugen. The palette side data packet is sent alright in
> matroskadec.c, the problem is that MPlayer sends ANOTHER palette side data
> AFTERWARDS, using whatever is in extradata as the palette. Complain at the
> authors of MPlayer, not me.
> >
> 
> If anything it sounds like a bug in mplayer, not FFmpeg.

  I may be totally of the mark, but wasn't it fixed in MPlayer with r37563:

  Date:   Sat Dec 12 17:34:35 2015 +0000

    mpcodecs/vd_ffmpeg: Do not overwrite palette with random extradata.
    

  If yes, I think we have some miscommunication going on here.


  Alexander