[FFmpeg-devel] [PATCH v9] lavf: palettized QuickTime video in Matroska

Mats Peterson matsp888 at yahoo.com
Mon Dec 28 14:13:17 CET 2015


On 12/28/2015 02:09 PM, Mats Peterson wrote:
> On 12/28/2015 02:03 PM, Michael Niedermayer wrote:
>> On Mon, Dec 28, 2015 at 11:46:21AM +0100, Mats Peterson wrote:
>>> On 12/28/2015 10:34 AM, Michael Niedermayer wrote:
>>>> On Mon, Dec 28, 2015 at 03:10:18AM +0000, Carl Eugen Hoyos wrote:
>>>>> Michael Niedermayer <michael <at> niedermayer.cc> writes:
>>>>>
>>>>>> Patch splited in move and matroska part
>>>>>> i removed this memcpy() for now from what i
>>>>>> commited as there is clearly no consenus on it
>>>>>
>>>>> I would really have appreciated a real review:
>>>>> Apart from the unrelated audio fix
>>>>
>>>> what audio fix ?
>>>>
>>>
>>> He probably means the change from 86 to 36 as the lower limit for
>>> private data in A_QUICKTIME (36 is the size of a version 0 sound
>>> sample description).
>>
>> right, i missed that
>> that one should have been a seperate patch
>>
>> [...]
>>
>>
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>
> Well, the proper value, as I said, is 36 rather than 86. Should we redo
> that part, or is it OK to keep it in the patchset?
>
> Mats
>

Or could you perhaps extract and apply that change on your side, or 
should I create a single patch for that one on my side?

Mats

-- 
Mats Peterson
http://matsp888.no-ip.org/~mats/


More information about the ffmpeg-devel mailing list