[FFmpeg-devel] [PATCH] lavfi/af_anequalizer: remove cabs, cexp dependencies

Matt Oliver protogonoi at gmail.com
Tue Dec 29 07:27:02 CET 2015


On 29 December 2015 at 11:51, Ganesh Ajjanagadde <gajjanagadde at gmail.com>
wrote:

> On Mon, Dec 28, 2015 at 8:22 AM, Paul B Mahol <onemda at gmail.com> wrote:
> > On 12/27/15, Ganesh Ajjanagadde <gajjanagadde at gmail.com> wrote:
> >> Replaces by real arithmetic. Tested the validity of these
> transformations
> >> separately.
> >>
> >> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
> >> ---
> >>  configure                    |  1 -
> >>  libavfilter/af_anequalizer.c | 25 +++++++++++++++++--------
> >>  2 files changed, 17 insertions(+), 9 deletions(-)
> >>
> >
> > If those are mathematically equivalent ok.
>
> mathematically equivalent, tested offline, numerical differences of
> the order of ~ 1e-15 or so, which is perfectly fine IMHO for double
> precision especially since it is a priori not clear which is more
> precise. Pushed, thanks.


Wouldn't it also be a good idea to remove the COMPLEX_FUNCS list from
configure as now neither cabs or cexp are used so configure can be
simplified by removing the checks for them.


More information about the ffmpeg-devel mailing list