[FFmpeg-devel] [PATCH v2] lavf/qtpalette: Treat 1-bit video as palettized

[Michael Niedermayer]

On Tue, Dec 29, 2015 at 05:42:26PM +0000, Carl Eugen Hoyos wrote:
> Michael Niedermayer <michael <at> niedermayer.cc> writes:
> 
> > On Tue, Dec 29, 2015 at 04:56:26PM +0000, Carl Eugen Hoyos wrote:
> > > Michael Niedermayer <michael <at> niedermayer.cc> writes:
> > > 
> > > > > https://drive.google.com/open?id=0B3_pEBoLs0faUlItWm9KaGJSTEE
> > > > 
> > > > patch applied
> > > 
> > > How exactly did you test this?
> > 
> > it is neccessary to also fix the decoder to test
> 
> (I disagree.)

> If that were true, more time should be given for 
> reviews imo.

yes


> 
> > this was a fix for just the demuxer side
> 
> If you cannot test, how do you know it is correct?

it works with the now available patch fixing the decoder and the
Earth\ Spin\ 1-bit\ qtrle.mov
file

I dont know if bugs remain, if there are any bugs/issues left, they
should be fixed of course ...


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151230/7f3acaf9/attachment.sig>