[FFmpeg-devel] [PATCH] configure: make gcc 2 detection more robust

[Ganesh Ajjanagadde]

On Wed, Dec 30, 2015 at 7:45 AM, Michael Niedermayer
<michael at niedermayer.cc> wrote:
> On Tue, Dec 29, 2015 at 07:05:20PM -0800, Ganesh Ajjanagadde wrote:
>> Solves an issue that will get triggered when gcc 20 rolls in.
>>
>> Found-by: Hendrik Leppkes <h.leppkes at gmail.com>
>> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
>> ---
>>  configure | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index 4bf72a6..76dcf38 100755
>> --- a/configure
>> +++ b/configure
>> @@ -3700,7 +3700,8 @@ probe_cc(){
>>          gcc_ext_ver=$(expr "$gcc_version" : ".*$gcc_pkg_ver $gcc_basever \\(.*\\)")
>>          _ident=$(cleanws "gcc $gcc_basever $gcc_pkg_ver $gcc_ext_ver")
>>          case $gcc_basever in
>> -            2*) ;;
>> +            2) ;;
>> +            2.*) ;;
>>              *) _depflags='-MMD -MF $(@:.o=.d) -MT $@' ;;
>
> ive no way to test this but it should be ok

My testing was with a simple shell script that fed in various strings
for $gcc_basever (2, 2.2, 20, 5.2, etc), and checking if they made
sense. Proper testing is hard, as gcc 2 is more or less obsolete, and
20 is some years down the road. Pushed, thanks.

>
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> The greatest way to live with honor in this world is to be what we pretend
> to be. -- Socrates
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>