[FFmpeg-devel] [PATCH v4 11/14] mips: do not disable any feature for generic cores

[Michael Niedermayer]

On Fri, Dec 04, 2015 at 03:48:27PM +0000, Vicente Olivert Riera wrote:
> We don't know which features are available when the user selects a
> generic core, so don't disable anything by default and let the user
> decide.
> 
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera at imgtec.com>
> ---
> Changes v3 -> v4:
>  - Minor change in the commit log: remove "let's".
> 
> Changes v2 -> v3:
>  - Change the logic of this patch. Instead of removing the generic core,
>    do not disable any feature and add a warning message to state that.
>    The patch subject has also changed accordingly.
> 
> Changes v1 -> v2:
>  - Nothing.
> 
> 
>  configure | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 8bd47b9..2ee10db 100755
> --- a/configure
> +++ b/configure
> @@ -4159,8 +4159,8 @@ elif enabled mips; then
>              esac
>          ;;
>          generic)
> -            disable mips64r6
> -            disable msa
> +            # We do not disable anything. Is up to the user to disable
> +            # the unwanted features.

i just noticed now but this breaks build

make distclean ; ./configure --cross-prefix=/usr/mips-linux-gnu/bin/ --cc='ccache mips-linux-gnu-gcc-4.4' --arch=mips --target-os=linux --enable-cross-compile && make -j12

CC      libavcodec/mips/blockdsp_msa.o
In file included from ffmpeg/libavcodec/mips/blockdsp_msa.c:21:
ffmpeg/libavutil/mips/generic_macros_msa.h:25:17: warning: msa.h: No such file or directory
ffmpeg/libavcodec/mips/blockdsp_msa.c: In function ‘copy_8bit_value_width8_msa’:
ffmpeg/libavcodec/mips/blockdsp_msa.c:29: error: ‘v16u8’ undeclared (first use in this function)
ffmpeg/libavcodec/mips/blockdsp_msa.c:29: error: (Each undeclared identifier is reported only once
ffmpeg/libavcodec/mips/blockdsp_msa.c:29: error: for each function it appears in.)
ffmpeg/libavcodec/mips/blockdsp_msa.c:29: error: expected ‘;’ before ‘val0’
ffmpeg/libavcodec/mips/blockdsp_msa.c:31: error: ‘val0’ undeclared (first use in this function)
ffmpeg/libavcodec/mips/blockdsp_msa.c:31: error: expected ‘;’ before ‘__msa_fill_b’
ffmpeg/libavcodec/mips/blockdsp_msa.c:32: error: implicit declaration of function ‘__msa_copy_u_d’
ffmpeg/libavcodec/mips/blockdsp_msa.c:32: error: ‘v2i64’ undeclared (first use in this function)
ffmpeg/libavcodec/mips/blockdsp_msa.c:32: error: expected ‘)’ before ‘val0’
ffmpeg/libavcodec/mips/blockdsp_msa.c: In function ‘copy_8bit_value_width16_msa’:
ffmpeg/libavcodec/mips/blockdsp_msa.c:44: error: ‘v16u8’ undeclared (first use in this function)
ffmpeg/libavcodec/mips/blockdsp_msa.c:44: error: expected ‘;’ before ‘val0’
ffmpeg/libavcodec/mips/blockdsp_msa.c:46: error: ‘val0’ undeclared (first use in this function)
ffmpeg/libavcodec/mips/blockdsp_msa.c:46: error: expected ‘;’ before ‘__msa_fill_b’
ffmpeg/libavcodec/mips/blockdsp_msa.c:49: error: expected expression before ‘)’ token
ffmpeg/libavcodec/mips/blockdsp_msa.c:49: error: expected expression before ‘)’ token
ffmpeg/libavcodec/mips/blockdsp_msa.c:49: error: expected expression before ‘)’ token
ffmpeg/libavcodec/mips/blockdsp_msa.c:49: error: expected expression before ‘)’ token
ffmpeg/libavcodec/mips/blockdsp_msa.c:49: error: expected expression before ‘)’ token
ffmpeg/libavcodec/mips/blockdsp_msa.c:49: error: expected expression before ‘)’ token
ffmpeg/libavcodec/mips/blockdsp_msa.c:49: error: expected expression before ‘)’ token
ffmpeg/libavcodec/mips/blockdsp_msa.c:49: error: expected expression before ‘)’ token
ffmpeg/libavcodec/mips/blockdsp_msa.c: In function ‘memset_zero_16width_msa’:
ffmpeg/libavcodec/mips/blockdsp_msa.c:58: error: ‘v16u8’ undeclared (first use in this function)
ffmpeg/libavcodec/mips/blockdsp_msa.c:58: error: expected ‘;’ before ‘zero’
ffmpeg/libavcodec/mips/blockdsp_msa.c:61: error: expected expression before ‘)’ token
ffmpeg/libavcodec/mips/blockdsp_msa.c:61: error: ‘zero’ undeclared (first use in this function)
ffmpeg/libavcodec/mips/blockdsp_msa.c:63: error: expected expression before ‘)’ token
make: *** [libavcodec/mips/blockdsp_msa.o] Error 1


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151230/c725b204/attachment.sig>