[FFmpeg-devel] [PATCH] Factorize avpriv_mirror() out

[Michael Niedermayer]

On Sun, Jan 04, 2015 at 10:26:00AM +0100, Clément Bœsch wrote:
> On Sun, Jan 04, 2015 at 12:43:26AM -0300, James Almer wrote:
> > On 04/01/15 12:32 AM, Michael Niedermayer wrote:
> > > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > > ---
> > >  libavcodec/dirac_dwt.c     |   30 +++++++------------
> > >  libavcodec/snow_dwt.c      |   70 +++++++++++++++++++-------------------------
> > >  libavfilter/transform.c    |   14 ++-------
> > >  libavfilter/vf_owdenoise.c |   17 +++--------
> > >  libavfilter/vf_sab.c       |   19 ++----------
> > >  libavutil/common.h         |   14 +++++++++
> > >  6 files changed, 63 insertions(+), 101 deletions(-)
> > 
> > libavutil/common.h is an installed header. Wouldn't it make more sense to use the av_ 
> > prefix like every other function above this one?

i could do that


> 
> Or just let it half private by having it in an internal.h header.

i could do that as well

if noone else states a preferrance then ill go with internal.h

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct answer.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150104/f0b58320/attachment.asc>