[FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

[Stefano Sabatini]

On date Wednesday 2015-01-21 20:38:20 +0530, Arwa Arif encoded:
> >
> > I still expect that eq and eq2 should have the same performances,
> > since the adjust callback is set depending on the parameter values. So
> > we should have a single eq filter.
> >
> > Please investigate about why you get different benchmark values.
> >
> 
> I used this command: ffmpeg -benchmark -i  matrixbench_mpeg2.mpg -vf mp=eq2
> -f null -
> And everytime I am running this command, I am getting a different result
> even for the same input and same filter.
> 

> So, I tried using the time.h library for getting the time, the results for
> eq and eq2 are 37.71 and 35.56 seconds respectively.

Please show the patch adding time.h benchmarks (in general making
things easily reproduce helps *a lot* the tester and the reviewer).

time.h usually works by creating log messages about the specific code
segment called performance, it doesn't affect global execution time,
so it looks like your benchmark was probably misguided.

> I don't know why eq is coming out to be slower than eq2. (In fact, eq2 is
> accessing more functions than eq).
-- 
FFmpeg = Fascinating and Fundamental Miracolous Philosofic Enlightened Guru