[FFmpeg-devel] [PATCH] Decoder for CEA-608 and World System Teletext [WIP]

[wm4]

On Fri, 23 Jan 2015 13:40:36 +0100
Hendrik Leppkes <h.leppkes at gmail.com> wrote:

> On Fri, Jan 23, 2015 at 1:33 PM, wm4 <nfxjfg at googlemail.com> wrote:
> 
> > On Fri, 23 Jan 2015 04:42:22 +0100
> > Michael Niedermayer <michaelni at gmx.at> wrote:
> >
> > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> > > index 99467bb..6a0fb5b 100644
> > > --- a/libavcodec/avcodec.h
> > > +++ b/libavcodec/avcodec.h
> > > @@ -503,11 +503,13 @@ enum AVCodecID {
> > >      AV_CODEC_ID_SSA,
> > >      AV_CODEC_ID_MOV_TEXT,
> > >      AV_CODEC_ID_HDMV_PGS_SUBTITLE,
> > > -    AV_CODEC_ID_DVB_TELETEXT,
> > > +    AV_CODEC_ID_DVB_VBI,
> >
> > Breaks everything, including API and ABI. I guess that's why the patch
> > is "WIP"?
> >
> 
> Unless I missed something else, ABI is unaffected since the values didn't
> change, just the name of the enum entry. A #define would take care of that
> from the API side of things.

That would imply the new codec ID is actually compatible with the old
one. Should it still be renamed?