[FFmpeg-devel] [PATCH] Port mp=eq/eq2 to lavfi

[Michael Niedermayer]

On Tue, Jan 27, 2015 at 06:32:13PM +0530, arwa arif wrote:
> On Tue, Jan 27, 2015 at 3:26 PM, Stefano Sabatini <stefasab at gmail.com>
> wrote:
> 
> > On date Monday 2015-01-26 13:20:49 +0100, Michael Niedermayer encoded:
> > > On Mon, Jan 26, 2015 at 11:31:49AM +0100, Christophe Gisquet wrote:
> > [...]
> > > > To me, it looks like just a normal
> > > > clipping is needed.
> > >
> > > yes
> > >
> > > also on a differnt topic, i think "gamma*" should be removed from
> > > eq, the implementation is simply wrong and it cannot be done
> > > conveniently in a yuv based filter.
> > > we already have lut based filters for rgb space, they could easily
> > > do correct gamma, a "gamma" filter could be added based on that
> >
> > BTW, eq is not bitexact with mp=eq2 and differs in many parts of the
> > code (yes, I realized this after removing mp=eq/eq2, so this is partly
> > my fault). For example the LUT16 part of the code is entirely missing.
> >
> >
> I have included lut16 in the code. Also, I tested it with various options,
> and it is coming out to be bit exact.

lut16 could be put back in and tested if its faster
it simply transforms 2 pixels at a time

the patch was missing some bits of the lut16 code

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150127/e49a66db/attachment.asc>