[FFmpeg-devel] [PATCH] avfilter: Port mp=softpulldown to lavfi

[Michael Niedermayer]

On Tue, Jan 27, 2015 at 08:10:04PM +0100, Michael Niedermayer wrote:
> On Tue, Jan 27, 2015 at 11:14:36AM +0000, Paul B Mahol wrote:
> > Signed-off-by: Paul B Mahol <onemda at gmail.com>
> > ---
> > Not-bitexact, dunno why. Do not have actual samples to test.
> 
> this change is needed:
> 
> @@ -134,6 +134,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in)
>              ret = ff_filter_frame(outlink, new);
>              state = 0;
>          } else {
> +            av_frame_make_writable(out);
>              for (i = 0; i < s->nb_planes; i++) {
>                  av_image_copy_plane(out->data[i], out->linesize[i] * 2,
>                                      in->data[i], in->linesize[i] * 2,
> 
> and should be ok if its bitexact with that (didnt try)

the filter probably needs a av_frame_make_writable() call
before the other av_image_copy_plane() too

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150128/425dcc7d/attachment.asc>