[FFmpeg-devel] [PATCH] avfilter: Port mp=softpulldown to lavfi

[Stefano Sabatini]

On date Wednesday 2015-01-28 15:13:27 +0000, Paul B Mahol encoded:
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
> Bit-exact with mp=softpulldown except first frame which is uninitialized data in mp filter.
> TODO: pts needs update, workaround is to use setpts filter.
> ---
>  LICENSE.md                    |   1 +
>  configure                     |   1 +
>  doc/filters.texi              |   9 +++
>  libavfilter/Makefile          |   1 +
>  libavfilter/allfilters.c      |   1 +
>  libavfilter/vf_softpulldown.c | 178 ++++++++++++++++++++++++++++++++++++++++++
>  6 files changed, 191 insertions(+)
>  create mode 100644 libavfilter/vf_softpulldown.c
> 
> diff --git a/LICENSE.md b/LICENSE.md
> index fb52cad..7add63c 100644
> --- a/LICENSE.md
> +++ b/LICENSE.md
> @@ -48,6 +48,7 @@ Specifically, the GPL parts of FFmpeg are:
>      - vf_pullup.c
>      - vf_sab.c
>      - vf_smartblur.c
> +    - vf_softpulldown.c
>      - vf_spp.c
>      - vf_stereo3d.c
>      - vf_super2xsai.c
> diff --git a/configure b/configure
> index 80985cb..ad8186f 100755
> --- a/configure
> +++ b/configure
> @@ -2618,6 +2618,7 @@ select_filter_select="pixelutils"
>  smartblur_filter_deps="gpl swscale"
>  showspectrum_filter_deps="avcodec"
>  showspectrum_filter_select="rdft"
> +softpulldown_filter_deps="gpl"
>  spp_filter_deps="gpl avcodec"
>  spp_filter_select="fft idctdsp fdctdsp me_cmp pixblockdsp"
>  stereo3d_filter_deps="gpl"
> diff --git a/doc/filters.texi b/doc/filters.texi
> index 009cab3..7ab971d 100644
> --- a/doc/filters.texi
> +++ b/doc/filters.texi
> @@ -8371,6 +8371,15 @@ in [-30,0] will filter edges. Default value is 0.
>  If a chroma option is not explicitly set, the corresponding luma value
>  is set.
>  
> + at section softpulldown

Add initial description:

Apply MPEG soft 3:2 pulldown.

> +
> +This filter acts on the MPEG-2 flags used for soft 3:2 pulldown
> +(soft telecine).
> +
> +It uses the mpeg2 video header information to make 29.97 fps out

nit: MPEG-2

> +of 23.976 fps soft telecined material.

> +This should help especially for dvds which are partly soft telecined.

DVDs ...

Possibly add a more extended use-case (also, who's willing to write
something on the wiki about telecined content and pulldown?).

[...]
> +AVFilter ff_vf_softpulldown = {
> +    .name          = "softpulldown",

> +    .description   = NULL_IF_CONFIG_SMALL("Apply MPEG soft 3:2 pulldown"),

Missing final dot at the end of description.

[...]
-- 
FFmpeg = Fancy Fundamentalist Minimalistic Portable Ecumenical Gangster