[FFmpeg-devel] [PATCH 3/3] x86/hevc: add ff_hevc_sao_band_filter_{8, 10, 12}_{sse2, avx2}

[Christophe Gisquet]

Hi,

and hopefully the last comments.

2015-01-30 19:50 GMT+01:00 James Almer <jamrial at gmail.com>:
> +%if mmsize > 16
> +    cmp           widthq, 16
> +    je hevc_sao_band_filter_16_%1 %+ SUFFIX
> +%endif
> +    cmp           widthq, 8
> +    je hevc_sao_band_filter_8_%1 %+ SUFFIX
> +%endmacro

Frankly a width of < 16 is quite unlikely. You bothered with it, but
if it goes any issue down the drain it should be dropped.

Secondly, shouldn't the jump be to the .loop location, and not the
function start?

Third, 64 and 32 are the more likely size, I'd probably unroll
accordingly. (eg loop64, loop32, loop16).

-- 
Christophe