[FFmpeg-devel] Subject: [PATCH] libavcodec/qsv.c: Linux-only code part has been moved to separate function in order to avoid the "ISO C90 forbids mixed declarations and code" compiler warning.

[Michael Niedermayer]

On Mon, Jul 06, 2015 at 09:37:52PM +0300, Ivan Uskov wrote:
> Hello All,
> 
> Unfortunately, previous patch for  libavcodec/qsv.c at the commit
> db89f45535aa3e99bceb5f6bf957c90e7ca39841 does initiate the compiler warning
> "ISO C90 forbids mixed declarations and code" under linux platform,
> because there is declaration block under preprocessor condition. Looks
> like it can not be re-arranged by graceful way into one function.
> I believe the best way to fix it is moving linux-related code into own
> separate function. Suggested patch does this.
> Please review. Thank.
>   
> 
> -- 
> Best regards,
>  Ivan                          mailto:ivan.uskov at nablet.com

>  qsv.c |   75 +++++++++++++++++++++++++++++++++++++-----------------------------
>  1 file changed, 43 insertions(+), 32 deletions(-)
> b7dd7946650407cfe3e1dc1ae834398549fb04b1  0001-libavcodec-qsv.c-Linux-only-code-part-has-been-moved.patch
> From c7d6fd4471d1aa41b163b28f3adbc37dddd28844 Mon Sep 17 00:00:00 2001
> From: Ivan Uskov <ivan.uskov at nablet.com>
> Date: Mon, 6 Jul 2015 18:04:13 +0300
> Subject: [PATCH] libavcodec/qsv.c: Linux-only code part has been moved to
>  separate function in order to avoid the "ISO C90 forbids mixed declarations
>  and code" compiler warning.

applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150707/068b6671/attachment.sig>