[FFmpeg-devel] [PATCH v4] Add support for Audible AAX (and AAX+) files

[Carl Eugen Hoyos]

Vesselin Bontchev <vesselin.bontchev <at> yandex.com> writes:

> +    ffio_read_size(pb, output, 8); // go to 
> offset 8, absolute postion 0x251

Sorry if I misunderstand the code, but I believe 
this should be "avio_skip()"

> +    ffio_read_size(pb, input, DRM_BLOB_SIZE);

Is there a disadvantage using avio_read()?

> +    av_log(c->fc, AV_LOG_ERROR, "[aax] mismatch in checksums!\n");
> +    return AVERROR_INVALIDDATA;

Imo, printing the error is sufficient, no need 
to fail, but that may just be me...

Carl Eugen