[FFmpeg-devel] [PATCH v4] Add support for Audible AAX (and AAX+) files

[wm4]

On Wed, 15 Jul 2015 23:03:07 +0200
Nicolas George <george at nsup.org> wrote:


> > +
> > +#define DRM_BLOB_SIZE 56
> > +
> > +static int mov_read_adrm(MOVContext *c, AVIOContext *pb, MOVAtom atom)
> > +{
> > +    // extracted from libAAX_SDK.so and AAXSDKWin.dll files!
> > +    unsigned char fixed_key[] = { 0x77, 0x21, 0x4d, 0x4b, 0x19, 0x6a, 0x87, 0xcd,
> > +                                  0x52, 0x00, 0x45, 0xfd, 0x20, 0xa5, 0x1d, 0x67 };
> 
> > +    unsigned char intermediate_key[20] = {0};
> > +    unsigned char intermediate_iv[20] = {0};
> > +    unsigned char input[64] = {0};
> > +    unsigned char output[64] = {0};
> > +    unsigned char file_checksum[20] = {0};
> > +    unsigned char file_checksum_encoded[41] = {0};
> > +    unsigned char file_key_encoded[41] = {0};
> > +    unsigned char file_iv_encoded[41] = {0};
> 
> Do you need to init to 0? The compiler or valgrind can detect access to
> uninitialized memory, if you init to 0, they can not do it.

Initializing them is always safer. Valgrind doesn't catch everything
either.