[FFmpeg-devel] [PATCH] avfilter: add Dynamic Audio Normalizer filter

[Paul B Mahol]

On 7/17/15, James Darnley <james.darnley at gmail.com> wrote:
> On 2015-07-09 18:55, Paul B Mahol wrote:
>> +    { "n", "enable channels coupling", OFFSET(channels_coupled),
>> AV_OPT_TYPE_INT, {.i64 = 1}, 0, 1, FLAGS },
>
> This should be "enable channel coupling"

Fixed

>
>> +static const double s_pi =
>> 3.1415926535897932384626433832795028841971693993751058209749445923078164062862089986280348253421170679;
>
> Why not use the standard M_PI define?

Its too short. And I try hard to produce exact same output as
reference implementation as possible, even if doubles are used.

>
>> +static void init_gaussian_filter(DynamicAudioNormalizerContext *s)
>> +{
>> +    double total_weight = 0.0;
>> +    const double sigma = (((s->filter_size / 2.0) - 1.0) / 3.0) + (1.0 /
>> 3.0);
>> +    double adjust;
>> +    int i;
>> +
>> +    // Pre-computer constants
>
> "Pre-compute constants"

Fixed.

>
>
>